From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
---|---|
To: | Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: macaddr 64 bit (EUI-64) datatype support |
Date: | 2016-10-12 23:44:57 |
Message-ID: | CAJrrPGe38wjFZhUVDY5kRcViwLsUJtZs8ak345M9YWTtLHtkBA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Oct 13, 2016 at 7:31 AM, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>
wrote:
> Haribabu Kommi, why have you read enough about EUI-64?
> Your function "macaddr64_trunc" sets 4 lower bytes as 0 whereas
> (according to the Wikipedia, but I can look for a standard) 3 bytes
> are still define an OUI (organizationally unique identifier), so
> truncation should be done for 5, not 4 lower octets.
>
> The macros "hibits" should be 3 octets long, not 4; "lobits" --- 5 bytes,
> not 4.
> In the other case your comparisons fail.
>
> What document have you used to write the patch? Are short form formats
> correct in macaddr64_in?
>
Yes, OUI is 24 bits. I just created prototype patch to check community
opinion on it.
I checked the following links [1], [2] for the development of macaddr8. But
the patch is
not correct for all the cases, it is just a prototype to see whether it
accepts 8 byte
MAC address or not?
[1] - http://standards.ieee.org/develop/regauth/tut/eui64.pdf
[2] - https://en.wikipedia.org/wiki/MAC_address
Regards,
Hari Babu
Fujitsu Australia
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-10-12 23:58:05 | Re: Rename max_parallel_degree? |
Previous Message | Andres Freund | 2016-10-12 23:38:38 | Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits. |