Re: checkpointer continuous flushing

From: Andres Freund <andres(at)anarazel(dot)de>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: checkpointer continuous flushing
Date: 2015-09-06 12:08:32
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Here's a bunch of comments on this (hopefully the latest?) version of
the patch:

* I'm not sure I like the FileWrite & FlushBuffer API changes. Do you
forsee other callsites needing similar logic? Wouldn't it be just as
easy to put this logic into the checkpointing code?

* We don't do one-line ifs; function parameters are always in the same
line as the function name

* Wouldn't a binary heap over the tablespaces + progress be nicer? If
you make the sorting criterion include the tablespace id you wouldn't
need the lookahead loop in NextBufferToWrite(). Isn't the current
approach O(NBuffers^2) in the worst case?


Andres Freund

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-09-06 12:25:00 Re: Summary of plans to avoid the annoyance of Freezing
Previous Message 2015-09-06 11:36:34 Re: [PATCH] Refactoring of LWLock tranches