| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Exposing PG_VERSION_NUM in pg_config |
| Date: | 2015-06-30 13:04:26 |
| Message-ID: | CAFj8pRD+GpUjgpFEiUqL=6rcaRR6-anx_f57td758iOKkNqLXQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Review:
1. Discussion - I read all discussion and majority opinion is positive to
this patch. I am for this patch too. I had to solve same issues with Orafce
project. More - this patch is terrible simple - it is just the publishing
already prepared value.
2. There was not any problem with patching, compilation, testing - It
should to have zero impact on PostgreSQL engine.
3. I rechecked it, and it is working
I have not any objection, so I'll mark this patch as ready for commit.
Regards
Pavel Stehule
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Syed, Rahila | 2015-06-30 13:12:43 | Re: [PROPOSAL] VACUUM Progress Checker. |
| Previous Message | Andres Freund | 2015-06-30 12:57:26 | Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel |