Re: Lack of Sanity Checking in file 'misc.c' for PostgreSQL 9.4.x

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, Bill Parker <wp02855(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Lack of Sanity Checking in file 'misc.c' for PostgreSQL 9.4.x
Date: 2015-06-15 12:34:21
Message-ID: 20150615123421.GB12001@feivel.credativ.lan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, Jun 15, 2015 at 04:35:47PM +0900, Michael Paquier wrote:
> So, here is a patch implementing those ideas. In code paths where a
> line number is available ecpg_raise() is called to report the error.
> In other paths ecpg_log() is used to log an "out of memory" message.
> Now, the routines of error.c, like ecpg_raise() can fail as well their
> malloc() call, hence it seems adapted to me to fallback to ecpg_log()
> and report the error to the user.
> Thoughts?

Sounds good to me. Patch committed.

Michael

--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2015-06-15 12:55:33 Re: BUG #13440: unaccent does not remove all diacritics
Previous Message Daniele Posenato 2015-06-15 10:56:29 After the restart of the PC, PGadmin III shows only the postgres database and not all the other local DBs