| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Michael Meskes <meskes(at)postgresql(dot)org> |
| Cc: | Bill Parker <wp02855(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Lack of Sanity Checking in file 'misc.c' for PostgreSQL 9.4.x |
| Date: | 2015-06-16 00:06:14 |
| Message-ID: | CAB7nPqRmSc24UPTtXE4DKTSi_kBQkfqsUWcsQPZUEgQSWagNnQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Jun 15, 2015 at 9:34 PM, Michael Meskes <meskes(at)postgresql(dot)org> wrote:
> On Mon, Jun 15, 2015 at 04:35:47PM +0900, Michael Paquier wrote:
>> So, here is a patch implementing those ideas. In code paths where a
>> line number is available ecpg_raise() is called to report the error.
>> In other paths ecpg_log() is used to log an "out of memory" message.
>> Now, the routines of error.c, like ecpg_raise() can fail as well their
>> malloc() call, hence it seems adapted to me to fallback to ecpg_log()
>> and report the error to the user.
>> Thoughts?
>
> Sounds good to me. Patch committed.
Thanks.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-06-16 00:52:48 | Re: BUG #13443: master will remove dead rows when hot standby(use slot) disconnect |
| Previous Message | Peter Geoghegan | 2015-06-15 22:47:01 | Re: BUG #13442: ISBN doesn't always roundtrip with text |