Re: Run pgindent now?

Bruce Momjian wrote:
> On Mon, May 25, 2015 at 04:52:38PM -0300, Alvaro Herrera wrote:
> > Bruce Momjian wrote:
> >
> > > OK, makes sense. You can see the old and 'all' diffs here:
> > >
> > > http://momjian.us/expire/
> >
> > Something is wrong. See aclchk.c changes.
>
> Yes, this is what I was concerned about. "aclitem" was a typedef in 9.0
> and 9.1, and the use of that as a typedef in 9.4 is certainly odd:
>
> - aclitem.ai_grantor = grantorId;
> + aclitem. ai_grantor = grantorId;

Interesting. The #typedef line still appears up to 9.4; we only removed
it in master after we branched from 9.4.

I notice now that this function is mis-indented in 9.0 and 9.1 in
exactly this way. Perhaps we can just accept that 9.2 - 9.4 are going
to be identical to the older branches, and 9.5 and forward is going to
look saner. Or we could rename the variable and re-indent the older
branches if this is too bothersome. This doesn't happen anywhere else
AFAICT.

> > Also, sometime ago we changed pgindent rules so that dot-space-space is
> > not turned into dot-tab in comments anymore, and many places were
> > updated to change dot-tab to dot-space-space -- or something like that.
> > This wasn't done in back branches (probably only 9.4 and back), but it's
> > likely that we need to do something about that.
>
> This was done in the backbranches with entab -m (only C comment
> periods). In fact, the only way we could improve pgindent in such a
> comprehensive way was to run this in back-branches. It was considered
> safer than running pgindent as it only affected C comments.

Ah, I see now that you backpatched that. One less problem to care about.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services