Re: Run pgindent now?

On Mon, May 25, 2015 at 06:48:47PM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > On Mon, May 25, 2015 at 04:52:38PM -0300, Alvaro Herrera wrote:
> > > Bruce Momjian wrote:
> > >
> > > > OK, makes sense. You can see the old and 'all' diffs here:
> > > >
> > > > http://momjian.us/expire/
> > >
> > > Something is wrong. See aclchk.c changes.
> >
> > Yes, this is what I was concerned about. "aclitem" was a typedef in 9.0
> > and 9.1, and the use of that as a typedef in 9.4 is certainly odd:
> >
> > - aclitem.ai_grantor = grantorId;
> > + aclitem. ai_grantor = grantorId;
>
> Interesting. The #typedef line still appears up to 9.4; we only removed
> it in master after we branched from 9.4.
>
> I notice now that this function is mis-indented in 9.0 and 9.1 in
> exactly this way. Perhaps we can just accept that 9.2 - 9.4 are going
> to be identical to the older branches, and 9.5 and forward is going to
> look saner. Or we could rename the variable and re-indent the older
> branches if this is too bothersome. This doesn't happen anywhere else
> AFAICT.

Ah, OK. Seems I didn't update the git typedefs.list file for every
pgindent run so my quick cross-version grep failed, though I used the
right version for each run.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +