Re: Run pgindent now?

On Mon, May 25, 2015 at 04:52:38PM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
>
> > OK, makes sense. You can see the old and 'all' diffs here:
> >
> > http://momjian.us/expire/
>
> Something is wrong. See aclchk.c changes.

Yes, this is what I was concerned about. "aclitem" was a typedef in 9.0
and 9.1, and the use of that as a typedef in 9.4 is certainly odd:

- aclitem.ai_grantor = grantorId;
+ aclitem. ai_grantor = grantorId;

> Also, sometime ago we changed pgindent rules so that dot-space-space is
> not turned into dot-tab in comments anymore, and many places were
> updated to change dot-tab to dot-space-space -- or something like that.
> This wasn't done in back branches (probably only 9.4 and back), but it's
> likely that we need to do something about that.

This was done in the backbranches with entab -m (only C comment
periods). In fact, the only way we could improve pgindent in such a
comprehensive way was to run this in back-branches. It was considered
safer than running pgindent as it only affected C comments.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +