Re: unaccent module - two params function should be immutable

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unaccent module - two params function should be immutable
Date: 2013-09-24 21:36:58
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Sep 17, 2013 at 10:15:47AM -0400, Robert Haas wrote:
> On Sat, Sep 14, 2013 at 9:42 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> >> I have developed the attached patch based on your suggestion. I did not
> >> see anything in the code that would make it STABLE, except a lookup of a
> >> dictionary library:
> >>
> >> dictOid = get_ts_dict_oid(stringToQualifiedNameList("unaccent"),
> >> false);
> >
> > yes, it risk, but similar is with timezones, and other external data.
> That's a catalog lookup - not a reliance on external data.

Sorry, I was wrong. Only unaccent_dict() calls get_ts_dict_oid(), and
we aren't changing the signature of that function.

Bruce Momjian <bruce(at)momjian(dot)us>

+ It's impossible for everything to be true. +

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2013-09-24 22:14:06 Re: Minmax indexes
Previous Message Bruce Momjian 2013-09-24 21:25:51 Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block