Re: unaccent module - two params function should be immutable

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unaccent module - two params function should be immutable
Date: 2013-09-17 14:15:47
Message-ID: CA+TgmoasAyS3bQw4VHZ+H_dUHqbbN2NcvKdAKZTZFSmjGNTj3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 14, 2013 at 9:42 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> I have developed the attached patch based on your suggestion. I did not
>> see anything in the code that would make it STABLE, except a lookup of a
>> dictionary library:
>>
>> dictOid = get_ts_dict_oid(stringToQualifiedNameList("unaccent"),
>> false);
>
> yes, it risk, but similar is with timezones, and other external data.

That's a catalog lookup - not a reliance on external data.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-09-17 14:21:42 Re: json docs fixup
Previous Message Robert Haas 2013-09-17 14:14:16 Re: Re: Proposal/design feedback needed: WITHIN GROUP (sql standard ordered set aggregate functions)