| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: splitting *_desc routines |
| Date: | 2012-11-27 16:10:22 |
| Message-ID: | 20121127161022.GJ4227@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs escribió:
> On 23 November 2012 22:52, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> > ./access/rmgrdesc/xact_desc.c
> > ./access/rmgrdesc/heapdesc.c
>
> Could we have either all underscores _ or none at all for the naming?
Sure, removed them all.
Tom Lane escribió:
> FWIW, I'd vote for dumping all of these into *one* rmgrdesc directory
> (which may as well be under access/ since that's where the xlog code is),
> regardless of where the corresponding replay code is in the source tree.
> I don't think splitting them up into half a dozen directories adds
> anything except confusion. If you want, the header comment for each
> file could mention where the corresponding replay code lives.
Done that way.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| splitdesc-3.patch | text/x-diff | 75.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-11-27 16:34:38 | Re: splitting *_desc routines |
| Previous Message | Tom Lane | 2012-11-27 16:00:11 | Re: ilist.h fails cpluspluscheck |