Re: ilist.h fails cpluspluscheck

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ilist.h fails cpluspluscheck
Date: 2012-11-27 16:00:11
Message-ID: 19619.1354032011@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2012-11-27 01:14:27 -0500, Tom Lane wrote:
>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> Maybe some ifndef __cplusplus would help.

> Its rather easy to fix in the ilist code at least - the cases it points
> out are those where I took a slightly ugly shortcut to reduce some very
> minor code duplication...

> Some casts fix it,

Seems reasonable, committed.

I wonder if we could get a buildfarm member or two running
cpluspluscheck.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-11-27 16:10:22 Re: splitting *_desc routines
Previous Message Pavel Stehule 2012-11-27 15:58:19 Re: Materialized views WIP patch