REVIEW: EXPLAIN and nfiltered

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>
Subject: REVIEW: EXPLAIN and nfiltered
Date: 2011-01-20 03:16:51
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2010-01-15 11:37 PM +200, Marko Tiikkaja wrote:
> On 2010-11-18 5:45 PM +0200, Marko Tiikkaja wrote:
> > Here's a patch for showing in EXPLAIN ANALYZE the number of rows a plan
> > qual filtered from a node's input.
> Rebased against master.

This patch looked good, in general, to me. I added a few documentation
updates and a comment, but it's a very straight-forward patch as far as
I can tell. Passes all regressions and my additional testing.

commit fac899f7967ce74e14a90af9ca24e1a1f5a580e7
Author: Stephen Frost <sfrost(at)snowman(dot)net>
Date: Wed Jan 19 22:14:54 2011 -0500

Fix < & > in docs to be &lt; &gt;, as required.

commit 5fcdb75a646912b8b273703caf33dadb80122e1c
Author: Stephen Frost <sfrost(at)snowman(dot)net>
Date: Wed Jan 19 22:05:05 2011 -0500

Update documentation for EXPLAIN ANALYZE/nfiltered

This patch updates some documentation around EXPLAIN ANALYZE, whose
output has been changed by the patch which added nfiltered to it.

Also added a comment in the only place that seemed to need one.

commit 9ebb0108a217c2d3b7f815d1d902d6bdcc276104
Author: Stephen Frost <sfrost(at)snowman(dot)net>
Date: Wed Jan 19 21:33:28 2011 -0500

Add nfiltered in EXPLAIN ANALYZE

This patch add the number of rows a plan qual filtered from a node's
input to the EXPLAIN ANALYZE output.

Patch by: Marko Tiikkaja



Attachment Content-Type Size
explain_nfiltered.patch text/x-diff 6.3 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2011-01-20 03:48:16 Re: sepgsql contrib module
Previous Message Robert Haas 2011-01-20 03:16:47 Re: ALTER TABLE ... REPLACE WITH