Re: REVIEW: EXPLAIN and nfiltered

From: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
To: Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>
Cc: pgsql-hackers(at)postgresql(dot)org, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: REVIEW: EXPLAIN and nfiltered
Date: 2011-01-20 06:37:12
Message-ID: AANLkTinGC0TcgfMw7+kYWHZxEpfpAhxOpyd+mVf1Kwkf@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 20, 2011 at 12:16, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> This patch looked good, in general, to me.  I added a few documentation
> updates and a comment, but it's a very straight-forward patch as far as
> I can tell.  Passes all regressions and my additional testing.

Looks good and useful for me, too.

We need to adjust a bit more documentation. The patch changes all of
EXPLAIN ANALYZE outputs. When I grep'ed the docs with "loops=",
EXPLAIN ANALYZE is also used in perform.sgml and auto-explain.sgml
in addition to explain.sgml.

It's good to have documentation about "nfiltered" parameter. The best
place would be around the descriptions of "loops" in "Using EXPLAIN" page:

http://developer.postgresql.org/pgdocs/postgres/using-explain.html

--
Itagaki Takahiro

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2011-01-20 07:36:47 Re: SSI and Hot Standby
Previous Message Noah Misch 2011-01-20 06:37:03 Re: Snapshot synchronization, again...