Re: gSoC - ADD MERGE COMMAND - code patch submission

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Boxuan Zhai <bxzhai2010(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "heikki(dot)linnakangas(at)enterprisedb(dot)com" <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Subject: Re: gSoC - ADD MERGE COMMAND - code patch submission
Date: 2010-07-10 17:53:53
Message-ID: 18465.1278784433@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Fetter <david(at)fetter(dot)org> writes:
> By the way, "make check" fails here with attached initdb.log:

> creating system views ... FATAL: unrecognized token: "false"

Hm, I'd suspect something fouled up in keyword recognition.
Did you do a "make clean" and rebuild?

BTW, this patch is still a few bricks shy of a load, since there's no
kwlist.h change and so the new MERGE keyword couldn't possibly be
recognized. More generally, I'm wondering why the original .rar
submission was 300k (presumably compressed) and your diff is only
about 35k ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2010-07-10 19:29:07 Re: gSoC - ADD MERGE COMMAND - code patch submission
Previous Message David Fetter 2010-07-10 17:45:12 Re: gSoC - ADD MERGE COMMAND - code patch submission