| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| Date: | 2009-02-10 13:56:55 |
| Message-ID: | 20090210135655.GB3708@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
ITAGAKI Takahiro wrote:
> I tested this changes and found two issues:
>
> 1. fillfactor.* options are silently ignored when the table doesn't have
> toast relation. Should we notice the behabior to users?
> ex. NOTICE: toast storage parameters are ignored
> because the table doesn't have toast relations.
You mean "toast.* options"? If so, yes, they are silently ignored.
Maybe issuing a warning is not a bad idea. Care to propose a patch?
> 2. psql's \d+ doesn't show toast storage parameters.
>
> Neither \d+ for base tables nor toast relations show toast.* parameters
> though there are some values in pg_class.reloptions.
Yeah, this is a bug in psql. I neglected to update \d+ when I committed
the namespace patch. I'll investigate.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Bmomjian | 2009-02-10 14:10:10 | pg-migrator - src: Improve test to exclude TOAST indexes. |
| Previous Message | Euler Taveira de Oliveira | 2009-02-10 05:02:22 | Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernd Helmle | 2009-02-10 14:17:44 | HotStandby-Patch and WAL_DEBUG |
| Previous Message | Alvaro Herrera | 2009-02-10 13:53:35 | Re: temporarily stop autovacuum |