Re: Updated backslash consistency patch

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: David Fetter <david(at)fetter(dot)org>, Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Updated backslash consistency patch
Date: 2009-02-07 19:58:21
Message-ID: 200902071958.n17JwLh17209@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stephen Frost wrote:
-- Start of PGP signed section.
> * David Fetter (david(at)fetter(dot)org) wrote:
> > On Sun, Feb 01, 2009 at 04:54:08AM +0000, Grzegorz Jaskiewicz wrote:
> > > On 23 Jan 2009, at 00:03, Tom Lane wrote:
> > >> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > >>> Seeing this list reminded me of a pet-peeve.. \du and \dg
> > >>> actually show the same info, that's fine, but neither of them show
> > >>> the rolcanlogin value.
> > >>
> > >> +1 for fixing that.
> > >
> > > was it that easy, or I got it wrong?
> > >
> > > :)
> >
> > I think Stephen meant that they should add a column to the output.
> > Stephen?
>
> It was, but that was before the output-as-table changes were done. It
> looks like when those were committed, 'Cannot login' was added as an
> attribute. Having 'Can login' (as this patch proposes) seems reasonable
> to me.

We only document non-default settings, which is why 'can login' was
skipped, which I think is logical so I think the existing code is fine.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-02-07 20:06:00 Re: <note> on hash indexes
Previous Message Bruce Momjian 2009-02-07 19:47:05 Re: Is a plan for lmza commpression in pg_dump