Re: NDirectFileRead and Write

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: NDirectFileRead and Write
Date: 2008-09-12 10:24:34
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> * Let's rename them BufFileReadCount and BufFileWriteCount to reflect
> their actual purpose.

It looks good. No one uses NDirectFileRead/Write variables now,
so we can rename it freely.

BTW, we have the word 'Direct' in ShowBufferUsage().
Can I keep it as-is?

! Shared blocks: ...
! Local blocks: ...
! Direct blocks: <R> read, <W> written

> * In any case I agree that the current arrangement
> with execdebug.h declaring variables defined in bufmgr.c is just weird.


ITAGAKI Takahiro
NTT Open Source Software Center

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-09-12 10:41:40 Re: Synchronous Log Shipping Replication
Previous Message Simon Riggs 2008-09-12 10:19:30 Re: Transaction Snapshots and Hot Standby