From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com> |
Subject: | Re: Regression test fails when BLCKSZ is 1kB |
Date: | 2008-04-21 16:16:32 |
Message-ID: | 20080421161632.GA19341@svana.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Apr 21, 2008 at 02:25:31PM +0200, Peter Eisentraut wrote:
> > I think affected test should contain order by keyword.
>
> For previously established reasons, we don't want to add ORDER BY clauses to
> every test that might fail under exceptional circumstances so we test all
> plan types equally. I think very small block sizes are fairly exceptional,
> unless you have a reason up your sleeve why they are a good idea.
I wonder if it would be feasable to, whenever a regression test fails
to sort both files and compare again. This should tell you if the
difference are *only* rearrangement automatically, without having to
eyeball the output.
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Wöhrer | 2008-04-21 16:17:39 | [Pljava-dev] stack depth limit exceeded - patch possible? |
Previous Message | Bruce Momjian | 2008-04-21 16:15:44 | Re: Proposed patch - psql wraps at window width |