| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Brendan Jurd <direvus(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [GENERAL] ISO week dates |
| Date: | 2007-02-17 00:37:03 |
| Message-ID: | 20070217003703.GG9724@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Brendan Jurd escribió:
> On 2/17/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >Yes, it was: you now have two duplicate tests in timestamp.sql, and
> >no corresponding test in timestamptz.sql. It looks to me like the
> >submitter intended to be testing timestamp_tbl in the former file
> >and the same tests against timestamptz_tbl in the latter. Please
> >recheck the diff and fix.
> >
>
> Tom's right. Looking back at the patch, it was a simple coding error.
> The test in timestamptz.sql should have been querying TIMESTAMPTZ_TBL
> not TIMESTAMP_TBL. The intent was to run the same tests against both
> timestamp and timestamptz.
Thanks for the clarification. Would you have a look at the tests as
they are now and confirm that that's what you wanted?
>
> I'll have a patch for proper handling of invalid formatting codes
> soon. And I'll be sure to test it in every way I can find to do so.
Great.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-02-17 00:56:01 | Re: Avg performance for int8/numeric |
| Previous Message | Bruce Momjian | 2007-02-17 00:27:34 | Re: [GENERAL] ISO week dates |