Re: TM formating patch

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)hotmail(dot)com>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-patches(at)postgresql(dot)org
Subject: Re: TM formating patch
Date: 2007-02-08 18:36:24
Message-ID: 200702081836.l18IaOu07836@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Patch applied. Thanks.

I have not backpatched it to 8.2.X because I am unclear of the risk
involved. Suggestions?

---------------------------------------------------------------------------

Pavel Stehule wrote:
> >"Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com> writes:
> > > This patch correct bug, when localized day or month names was incorectly
> > > trnasformed to lower or upper string.
> >
> >I really dislike the API you've chosen for upper_str/lower_str ---
> >overwriting the input on the assumption that it's long enough is a
> >buffer overrun bug waiting to happen, because (at least in utf8)
> >changing case doesn't preserve the byte length of the string.
> >Please make them return a freshly palloc'd string instead.
> >
> > regards, tom lane
>
> I correct it, and test it for czech latin2 and utf8 case.
>
> Regards
> Pavel Stehule
>
> _________________________________________________________________
> Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-02-08 18:42:29 Re: patch for contrib/xml2
Previous Message Bruce Momjian 2007-02-08 17:04:45 Re: [pgsql-patches] Fixed shared_preload_libraries on Win32