Re: TM formating patch

From: "Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: pgsql-patches(at)postgresql(dot)org, bruce(at)momjian(dot)us
Subject: Re: TM formating patch
Date: 2007-02-05 20:53:31
Message-ID: BAY114-F169CD3857D9FA46937FC0FF9980@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

>"Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com> writes:
> > This patch correct bug, when localized day or month names was incorectly
> > trnasformed to lower or upper string.
>
>I really dislike the API you've chosen for upper_str/lower_str ---
>overwriting the input on the assumption that it's long enough is a
>buffer overrun bug waiting to happen, because (at least in utf8)
>changing case doesn't preserve the byte length of the string.
>Please make them return a freshly palloc'd string instead.
>
> regards, tom lane

I correct it, and test it for czech latin2 and utf8 case.

Regards
Pavel Stehule

_________________________________________________________________
Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/

Attachment Content-Type Size
TM_formatting.diff text/x-patch 10.6 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-02-05 21:40:41 Re: [pgsql-patches] Phantom Command IDs, updated patch
Previous Message Alvaro Herrera 2007-02-05 19:44:38 Re: [pgsql-patches] Phantom Command IDs, updated patch