Re: TM formating patch

From: "Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com>
To: bruce(at)momjian(dot)us
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-patches(at)postgresql(dot)org
Subject: Re: TM formating patch
Date: 2007-02-08 20:03:09
Message-ID: BAY20-F256B263A02BA65C3A17A52F99D0@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


>Patch applied. Thanks.
>
>I have not backpatched it to 8.2.X because I am unclear of the risk
>involved. Suggestions?

It's bug in 8.2. I don't know about any risks for 8.2

Pavel

>
>---------------------------------------------------------------------------
>
>
>Pavel Stehule wrote:
> > >"Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com> writes:
> > > > This patch correct bug, when localized day or month names was
>incorectly
> > > > trnasformed to lower or upper string.
> > >
> > >I really dislike the API you've chosen for upper_str/lower_str ---
> > >overwriting the input on the assumption that it's long enough is a
> > >buffer overrun bug waiting to happen, because (at least in utf8)
> > >changing case doesn't preserve the byte length of the string.
> > >Please make them return a freshly palloc'd string instead.
> > >
> > > regards, tom lane
> >
> > I correct it, and test it for czech latin2 and utf8 case.
> >
> > Regards
> > Pavel Stehule
> >
> > _________________________________________________________________
> > Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/
>
>[ Attachment, skipping... ]
>
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 3: Have you checked our extensive FAQ?
> >
> > http://www.postgresql.org/docs/faq
>
>--
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://www.enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +

_________________________________________________________________
Emotikony a pozadi programu MSN Messenger ozivi vasi konverzaci.
http://messenger.msn.cz/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-02-08 20:27:31 Re: [PATCHES] [pgsql-patches] Phantom Command IDs, updated patch
Previous Message Tom Lane 2007-02-08 20:00:03 Re: [PATCHES] [pgsql-patches] Phantom Command IDs, updated patch