Re: [PATCH] Add pretty-printed XML output option

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: [PATCH] Add pretty-printed XML output option
Date: 2023-02-16 22:12:09
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 16.02.23 00:13, Peter Smith wrote:
> Today I fetched and tried the latest v11.
> It is failing too, but only just.
> - see attached file pretty-v11-results
> It looks only due to a whitespace EOF issue in the xml_2.out
> @@ -1679,4 +1679,4 @@
> -- XML format: empty string
> SELECT xmlformat('');
> ERROR: invalid XML document
> -\set VERBOSITY default
> \ No newline at end of file
> +\set VERBOSITY default
> ------
> The attached patch update (v12-0002) fixes the xml_2.out for me.

I'm squashing v12-0001 and v12-0002 (v13 attached). There is still an
open discussion on renaming the function to xmlserialize,[1] but it
shouldn't be too difficult to change it later in case we reach a
consensus :)




Attachment Content-Type Size
v13-0001-Add-pretty-printed-XML-output-option.patch text/x-patch 28.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2023-02-16 22:36:40 Introduce list_reverse() to make lcons() usage less inefficient
Previous Message Nathan Bossart 2023-02-16 21:58:10 Re: recovery modules