| From: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
|---|---|
| To: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: [PATCH] Add pretty-printed XML output option |
| Date: | 2023-02-17 00:08:21 |
| Message-ID: | CAAhFRxjM4XZeQhKTfSKeQSyMAK6xssOu6UCT2rmVkBfi4NtmJQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 16, 2023 at 2:12 PM Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:
>
> I'm squashing v12-0001 and v12-0002 (v13 attached).
I've looked into the patch. The code looks to conform to usual expectations.
One nit: this comment should have just one asterisk.
+ /**
And I have a dumb question: is this function protected from using
external XML namespaces? What if the user passes some xmlns that will
force it to read namespace data from the server filesystem? Or is it
not possible? I see there are a lot of calls to xml_parse() anyway,
but still...
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-02-17 00:23:51 | Re: Introduce list_reverse() to make lcons() usage less inefficient |
| Previous Message | Andrey Borodin | 2023-02-16 23:33:07 | psql \watch 2nd argument: iteration count |