Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful

From: Andres Freund <andres(at)anarazel(dot)de>
To: Bruce Momjian <bruce(at)momjian(dot)us>,Greg Stark <stark(at)mit(dot)edu>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-core <pgsql-core(at)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful
Date: 2015-05-25 15:55:42
Message-ID: 1B40A9EB-4DD1-4C38-B8FB-3FB0CDF5E3C0@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On May 25, 2015 8:52:33 AM PDT, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>On Mon, May 25, 2015 at 04:37:59PM +0100, Greg Stark wrote:
>> What exactly is failing?
>>
>> Is it that fsync is returning -1 ? Should we just ignore errors from
>> fsync if it happens in this stage? That might be safer than
>> determining which files should or shouldn't be fsynced.
>
>Interesting idea. We could skip fsync -1 failures only for symbolic
>links.

Now there's already a thread on jackets about this.

Andres

---
Please excuse brevity and formatting - I am writing this on my mobile phone.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2015-05-25 16:05:47 Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful
Previous Message Alvaro Herrera 2015-05-25 15:52:48 Re: Incorrect processing of CREATE TRANSFORM with DDL deparding

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-05-25 16:05:47 Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful
Previous Message Bruce Momjian 2015-05-25 15:52:33 Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful