Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Greg Stark <stark(at)mit(dot)edu>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-core <pgsql-core(at)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful
Date: 2015-05-25 16:06:26
Message-ID: 20150525160626.GO26667@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

* Andres Freund (andres(at)anarazel(dot)de) wrote:
> On May 25, 2015 8:52:33 AM PDT, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >On Mon, May 25, 2015 at 04:37:59PM +0100, Greg Stark wrote:
> >> What exactly is failing?
> >>
> >> Is it that fsync is returning -1 ? Should we just ignore errors from
> >> fsync if it happens in this stage? That might be safer than
> >> determining which files should or shouldn't be fsynced.
> >
> >Interesting idea. We could skip fsync -1 failures only for symbolic
> >links.
>
> Now there's already a thread on jackets about this.

Agreed- we should probably keep the discussion about fixing it (or
addressing the original issue in some way that doesn't run into this
issue) on the other thread. This is simply to point out the user impact
and that we need to fix it quickly.

Thanks!

Stephen

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2015-05-25 16:09:51 Re: BUG #13348: PostgreSQL 9.5 sampletable BUG return rows not the same as reltuples*sample factor?
Previous Message Tom Lane 2015-05-25 16:05:47 Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-05-25 16:27:48 Re: fsync-pgdata-on-recovery tries to write to more files than previously
Previous Message Tom Lane 2015-05-25 16:05:47 Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful