Skip site navigation (1) Skip section navigation (2)

Re: Patch for Makefile race against current cvs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Klaus Naumann <knaumann(at)gmx-ag(dot)de>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch for Makefile race against current cvs
Date: 2001-11-12 21:13:29
Message-ID: 19404.1005599609@sss.pgh.pa.us (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-patches
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Tom Lane writes:
>> But we could provide some security for multiple children of a single
>> make by changing the rules to be like
>> 
>> $(srcdir)/parse.h: gram.y
>> ifdef YACC
>> $(YACC) -d $(YFLAGS) $<
>> mv y.tab.h $(srcdir)/parse.h
>> mv y.tab.c $(srcdir)/gram.c
>> else
>> @$(missing) bison $< $@
>> endif
>> 
>> $(srcdir)/gram.c: $(srcdir)/parse.h

> That seems to be okay, although I think I'd switch gram.c and parse.h for
> stylistic reasons.

It's not real important, but I thought it would be a good idea to
minimize the dependencies seen by sub-makes entering the directory from
other backend directories.  Those sub-makes will only be interested in
parse.h, not in gram.c.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2001-11-12 21:20:36
Subject: Re: Patch for Makefile race against current cvs
Previous:From: Stephan SzaboDate: 2001-11-12 21:07:39
Subject: Re: ALTER TABLE RENAME fix

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group