Re: add queryEnv to ExplainOneQuery_hook

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add queryEnv to ExplainOneQuery_hook
Date: 2018-01-11 17:02:36
Message-ID: 19370.1515690156@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Fri, Jan 12, 2018 at 12:16 AM, Tatsuro Yamada
> <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> I found a variable (queryEnv) which should be added in
>> ExplainOneQuery_hook because if it is missing, hook function
>> can't call ExplainOnePlan.

> Yeah, I think you're right. That's an oversight in 18ce3a4a.

Clearly :-(. Too bad we didn't find this sooner --- I suppose changing it
in v10 now is a nonstarter. Will push to HEAD though.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marina Polyakova 2018-01-11 17:21:11 master make check fails on Solaris 10
Previous Message Tom Lane 2018-01-11 16:54:54 Re: Minor code improvement to estimate_path_cost_size in postgres_fdw