Re: Minor code improvement to estimate_path_cost_size in postgres_fdw

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Minor code improvement to estimate_path_cost_size in postgres_fdw
Date: 2018-01-11 16:54:54
Message-ID: 19022.1515689694@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> The declaration of estimate_path_cost_size uses baserel, but
> the actual definition uses foreignrel. It would be better to sync.

Yeah, the join_conds parameter's been renamed at some point too :-(
Fixed.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-01-11 17:02:36 Re: add queryEnv to ExplainOneQuery_hook
Previous Message Rader, David 2018-01-11 16:47:52 [PATCH] ECPG bug fix in preproc when indicator struct is shorter than record struct