| From: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: add queryEnv to ExplainOneQuery_hook |
| Date: | 2018-01-12 01:45:48 |
| Message-ID: | 1ee489eb-7545-e227-3a7f-0804424fd3aa@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/01/12 2:02, Tom Lane wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> On Fri, Jan 12, 2018 at 12:16 AM, Tatsuro Yamada
>> <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>> I found a variable (queryEnv) which should be added in
>>> ExplainOneQuery_hook because if it is missing, hook function
>>> can't call ExplainOnePlan.
>
>> Yeah, I think you're right. That's an oversight in 18ce3a4a.
>
> Clearly :-(. Too bad we didn't find this sooner --- I suppose changing it
> in v10 now is a nonstarter. Will push to HEAD though.
>
> regards, tom lane
Thanks Tom!
I read that commit log on HEAD.
Regards,
Tatsuro Yamada
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-01-12 01:48:40 | Re: [HACKERS] Bug in to_timestamp(). |
| Previous Message | Tatsuro Yamada | 2018-01-12 01:43:40 | Re: add queryEnv to ExplainOneQuery_hook |