Re: [PATCH] Fix select from wrong table array_op_test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jason Kim <git(at)jasonk(dot)me>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Fix select from wrong table array_op_test
Date: 2021-06-11 15:31:15
Message-ID: 1882787.1623425475@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jason Kim <git(at)jasonk(dot)me> writes:
> In the middle of GIN index testing, there are some selects that are on
> a different table array_op_test that doesn't even have an index. They
> probably were supposed to be selects to table array_index_op_test like
> the other ones around the area.

I think it's probably intentional, else why have two tables at all?
I suppose the point of these test cases is to confirm that you get the
same results with or without use of an index.

Certainly, there's more than one way to do that. Perhaps we should
have only one table and perform the variant tests by manipulating
enable_indexscan et al. But I think what you did here is defeating
the intent.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2021-06-11 16:00:41 Re: [PATCH] Fix select from wrong table array_op_test
Previous Message Tom Lane 2021-06-11 15:26:41 Re: logical replication of truncate command with trigger causes Assert