Re: Dead code in win32.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Dead code in win32.h
Date: 2016-04-21 19:52:28
Message-ID: 18711.1461268348@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Perhaps I'm missing something, but if so, in what way is the
> "#if _MSC_VER >= 1600" stanza not totally useless given the
> immediately preceding macro redefinitions?

Some rummaging in the git history says that that stanza did something
when it was added (in 63876d3ba), but the later commit 73838b52 made
it redundant by making the earlier set of definitions unconditional.
Now it's merely confusing, so I'm going to take it out and repurpose
the comment.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christian Ullrich 2016-04-21 19:56:01 Re: VS 2015 support in src/tools/msvc
Previous Message Robert Haas 2016-04-21 19:47:50 Re: kqueue