Re: Dead code in win32.h

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Dead code in win32.h
Date: 2016-04-22 03:11:32
Message-ID: CAB7nPqSETfR8GTNBq60_Gs0MEuh1MGoo8F8A4rodZ_7XyQq55A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 22, 2016 at 4:52 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Perhaps I'm missing something, but if so, in what way is the
>> "#if _MSC_VER >= 1600" stanza not totally useless given the
>> immediately preceding macro redefinitions?
>
> Some rummaging in the git history says that that stanza did something
> when it was added (in 63876d3ba), but the later commit 73838b52 made
> it redundant by making the earlier set of definitions unconditional.
> Now it's merely confusing, so I'm going to take it out and repurpose
> the comment.

Going through that... That's indeed dead meat (found a bug on the way actually).
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-04-22 03:16:22 Missing lookup in msvcr120 for pgwin32_putenv
Previous Message Michael Paquier 2016-04-22 02:53:28 Re: Should XLogInsert() be done only inside a critical section?