| From: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, David Fetter <david(at)fetter(dot)org>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PGXS: REGRESS_OPTS=--load-language=plpgsql |
| Date: | 2010-02-19 07:34:26 |
| Message-ID: | 18602BCC-1854-4591-89A2-D9BC38F80887@kineticode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Feb 18, 2010, at 8:38 PM, Tom Lane wrote:
>> The regression test in the core is targeting only its version,
>> but some external projects have version-independent tests.
>
> I think it's more like "are under the fond illusion that their tests are
> version-independent". Are we going to back out the next incompatible
> change we choose to make as soon as somebody notices that it breaks a
> third-party test case? I don't think so. Let me point out that
> choosing to install plpgsql by default has already broken "--single"
> restore of practically every pg_dump out there. Nobody batted an eye
> about that. Why are we suddenly so concerned about its effects on
> unnamed test suites?
Because it's a lot easier for `pg_regress --load-language=plpgsql` to mean "ensure the language is installed" than it is for 3rd-party test suites to detect what version they're being installed against.
Really, all that has to happen is pg_regress in 8.5a4+ needs to just ignore `--load-language=plpgsql`. That's it.
Best,
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-02-19 07:49:39 | Re: PGXS: REGRESS_OPTS=--load-language=plpgsql |
| Previous Message | Heikki Linnakangas | 2010-02-19 06:30:46 | Re: testing cvs HEAD - HS/SR - PANIC: cannot make new WAL entries during recovery |