From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: 'make check' fails |
Date: | 2018-04-11 17:47:41 |
Message-ID: | 20180411174741.GA29757@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 11, 2018 at 01:04:56PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Wed, Apr 11, 2018 at 12:35:41PM -0400, Tom Lane wrote:
> >> We can fix this by making submake-generated-headers be a recursive
> >> prerequisite for "check" as well as "all" and "install". I wonder
> >> whether anybody is expecting any other shortcuts to work.
>
> > In case it wasn't clear, I can reproduce this failure without parallel
> > mode. FYI, the reason I used this shortcut is so I can just run one
> > command and check one error code to know if they all worked; see
> > src/tools/pgtest for an example.
>
> Probably, you got out of the habit of using parallel mode because it
> fell over from time to time. The way things were done before, there
> independently trying to update the same generated headers.
I do use parallel make but was testing without it just in case.
> Will commit a fix in a bit.
I can confirm the fix. Thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-04-11 17:55:17 | Re: lazy detoasting |
Previous Message | Chapman Flack | 2018-04-11 17:21:48 | Re: lazy detoasting |