Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Date: 2016-10-25 00:37:24
Message-ID: CAB7nPqRkc_82HB8o4GOhxTu1EceDueQs1uR3_AR-rwwjsQxTqA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Oct 25, 2016 at 6:59 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>>> An alternative that would be worth considering is to adopt a uniform
>>> rule of // for line-ending comments and /* for all other uses.
>
>> Why not. As far as comments are concerned, editors usually highlight them
>> in some color, and my eyes get used to the comment color, so the simpler &
>> shorter the better, really.
>
>>> We'd have to teach pgindent about that, and I dunno how hard that is.
>
>> Maybe it is enough to just to turn "/* no-nl */" to "// no-nl" in
>> pgindent's post_indent, but probably I'm too naïve:-)
>
> Well, IMO the point of making that change would be to buy an additional
> three characters of space for the comment before it wraps. So I'd suspect
> that post-processing is too late. But I've not looked into pgindent to
> see where the decisions are made exactly.

Well... Coming back to the subject, are there any recommendations from
committers? -std=c89 in CFLAGS does not seem to help much to detect
extra commas in enums, even if this has been added in C99.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2016-10-25 01:34:14 Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Previous Message Tom Lane 2016-10-24 21:59:53 Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2016-10-25 01:17:41 Re: Parallel tuplesort (for parallel B-Tree index creation)
Previous Message Merlin Moncure 2016-10-24 23:29:14 Re: emergency outage requiring database restart