From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Unused header file inclusion |
Date: | 2019-08-18 18:37:34 |
Message-ID: | 17463.1566153454@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> I've pushed the other ones.
Checking whether header files compile standalone shows you were overly
aggressive about removing fmgr.h includes:
In file included from /tmp/headerscheck.Ss8bVx/test.c:3:
./src/include/utils/selfuncs.h:143: error: expected declaration specifiers or '...' before 'FmgrInfo'
./src/include/utils/selfuncs.h:146: error: expected declaration specifiers or '...' before 'FmgrInfo'
./src/include/utils/selfuncs.h:152: error: expected declaration specifiers or '...' before 'FmgrInfo'
That's with a script I use that's like cpluspluscheck except it tests
with plain gcc not g++. I attached it for the archives' sake.
Oddly, cpluspluscheck does not complain about those cases, but it
does complain about
In file included from /tmp/cpluspluscheck.FgX2SW/test.cpp:4:
./src/bin/scripts/scripts_parallel.h:18: error: ISO C++ forbids declaration of 'PGconn' with no type
./src/bin/scripts/scripts_parallel.h:18: error: expected ';' before '*' token
./src/bin/scripts/scripts_parallel.h:29: error: 'PGconn' has not been declared
(My headerscheck script is missing that header; I need to update it to
match the latest version of cpluspluscheck.)
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
headerscheck | text/x-shellscript | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-08-18 18:59:53 | Re: Rethinking opclass member checks and dependency strength |
Previous Message | Tom Lane | 2019-08-18 16:41:23 | Re: [PATCH] minor doc fix for create-role |