| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unused header file inclusion |
| Date: | 2019-08-16 23:07:16 |
| Message-ID: | 20190816230716.jndus364yfcz4sr6@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-08-03 12:37:33 -0700, Andres Freund wrote:
> Think the first three are pretty clearly a good idea, I'm a bit less
> sanguine about the fourth:
> Headers like utils/timestamp.h are often included just because we need a
> TimestampTz type somewhere, or call GetCurrentTimestamp(). Approximately
> none of these need the PG_GETARG_* macros, which are the only reason for
> including fmgr.h in these headers. As they're macros that's not
> actually needed, although I think normally good style. But I' think here
> avoiding exposing fmgr.h to more headers is a bigger win.
I still think the fourth is probably worthwhile, but I don't feel
confident enough to do it without somebody else +0.5'ing it...
I've pushed the other ones.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2019-08-17 00:39:21 | Can't we give better table bloat stats easily? |
| Previous Message | Andres Freund | 2019-08-16 22:29:30 | Re: default_table_access_method is not in sample config file |