| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unused header file inclusion |
| Date: | 2019-08-19 00:50:51 |
| Message-ID: | 14803.1566175851@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> (My headerscheck script is missing that header; I need to update it to
> match the latest version of cpluspluscheck.)
I did that, and ended up with the attached. I'm rather tempted to stick
this into src/tools/ alongside cpluspluscheck, because it seems to find
rather different trouble spots than cpluspluscheck does. Thoughts?
As of HEAD (927f34ce8), I get clean passes from both this and
cpluspluscheck, except for the FmgrInfo references in selfuncs.h.
I tried it on RHEL/Fedora, FreeBSD 12, and current macOS.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| headerscheck | text/x-shellscript | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tara Anne | 2019-08-19 01:00:46 | Re: [PATCH] minor doc fix for create-role |
| Previous Message | Alvaro Herrera | 2019-08-19 00:18:40 | Re: pgsql: doc: Add some images |