From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Akshat Jaimini <destrex271(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Mikhail Zhilin <m(dot)zhilin(at)postgrespro(dot)ru> |
Subject: | Re: BUG: deadlock between autovacuum worker and client backend during removal of orphan temp tables with sequences |
Date: | 2024-04-02 19:04:54 |
Message-ID: | 1731082.1712084694@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Akshat Jaimini <destrex271(at)gmail(dot)com> writes:
> The code seems to implement the feature and has good and explanatory comments associated with it.
> I believe we can go ahead with committing patch although I would request some senior contributors to also take a look at this patch since I am relatively new to patch reviews.
Looks like a good catch and a reasonable fix. Pushed after rewriting
the comments a bit.
As far as this goes:
> I ran make installcheck-world after applying the patch and recompiling it. It did fail for a particular test but from the logs it seems to be unrelated to this particular patch since it fails for the following:
> ==========================
> select error_trap_test();
> - error_trap_test
> ----------------------------
> - division_by_zero detected
> -(1 row)
> -
> +ERROR: cannot start subtransactions during a parallel operation
... that's the test case from 0075d7894, and the failure is what
I'd expect from a backend older than that. Maybe you forgot to
recompile/reinstall after updating past that commit?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2024-04-03 00:00:01 | Re: Building with musl in CI and the build farm |
Previous Message | ケーブル | 2024-04-02 10:56:23 | Re: BUG #18416: Confirmation of Issue with PostgreSQL ODBC Driver for Windows |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-04-02 19:18:24 | Re: Missing LWLock protection in pgstat_reset_replslot() |
Previous Message | Daniel Gustafsson | 2024-04-02 18:55:41 | Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~? |