Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Date: 2016-10-24 19:51:32
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Mon, Oct 24, 2016 at 03:03:19PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Fabien COELHO wrote:
> >> I find it annoying that "//" comments are not supported, or having to
> >> declare variables at the beginning of a block instead of when first used...
> > I think some c99 features would be nice (variadic macros for one), but
> > those particular two get a big "meh" from me.
> Yeah. Personally, I'd want to continue the rule against // comments just
> as a matter of maintaining stylistic consistency. Code that's got a
> random mishmash of // and /* comments looks messy, if you ask me.
> An alternative that would be worth considering is to adopt a uniform
> rule of // for line-ending comments and /* for all other uses. We'd
> have to teach pgindent about that, and I dunno how hard that is.

I think it would be easy to teach pg_indent.

Bruce Momjian <bruce(at)momjian(dot)us>

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-10-24 20:09:34 pgsql: Stamp 9.6.1.
Previous Message Stephen Frost 2016-10-24 19:11:45 Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2016-10-24 20:04:24 Re: Rename max_parallel_degree?
Previous Message Victor Wagner 2016-10-24 19:38:57 Re: Patch: Implement failover on libpq connect level.