| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: commented out code |
| Date: | 2026-01-20 08:49:35 |
| Message-ID: | 8333bca3-2d7d-4513-b44d-a168e75171e9@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05.12.25 17:38, Heikki Linnakangas wrote:
> #if 0
> Oid subtype = PG_GETARG_OID(3);
> #endif
>
> is yet another option. It keeps the indentation, although you won't get
> the compiler checking.
After some reflection, I like this approach. It keeps the indentation
and enables syntax highlighting, so it makes some of these blocks much
easier to read.
Here is an updated patch with this approach, except for jsonb_set_lax(),
where the correct fix was to delete the commented out code, as
previously discussed.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-incorrect-commented-out-code.patch | text/plain | 1.2 KB |
| v2-0002-Mark-commented-out-code-as-unused.patch | text/plain | 46.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2026-01-20 08:54:01 | Re: Logical Replication of sequences |
| Previous Message | Heikki Linnakangas | 2026-01-20 08:43:09 | Re: Speed up transaction completion faster after many relations are accessed in a transaction |