| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | solaimurugan vellaipandiyan <drsolaimurugan(dot)v(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, Payal Singh <payals1(at)umbc(dot)edu>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments |
| Date: | 2026-05-11 05:04:54 |
| Message-ID: | 1678069.1778475894@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <johncnaylorls(at)gmail(dot)com> writes:
> On Mon, May 11, 2026 at 6:37 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think those are pretty much all improvements, except that it kind
>> of messes up Martin Utesch's ASCII-art signatures in the geqo files.
> Agreed, although this one now seems to use even more vertical space
> that doesn't contain anything:
> -/* Function works as follows:
> +/*
> + * Function works as follows:
> + *
> *
> *
> - * */
> + */
Yeah ... what's actually happening there is that it's replacing
* */
with
*
*/
although the diff misattributes the extra line. There are few
enough of those that I didn't think it was worth getting
excited about ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | solaimurugan vellaipandiyan | 2026-05-11 05:20:20 | Re: pull-up subquery if JOIN-ON contains refs to upper-query |
| Previous Message | John Naylor | 2026-05-11 04:46:06 | Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments |