Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: solaimurugan vellaipandiyan <drsolaimurugan(dot)v(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, Payal Singh <payals1(at)umbc(dot)edu>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
Date: 2026-05-11 04:46:06
Message-ID: CANWCAZbY43YfBVrsVwSafcxe4YdoaAwP1Keu9shcYA6GA=vnLQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 11, 2026 at 6:37 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Attached are a proposed v8 of the patch, plus two diff files showing
> the effects. v7-0001.diff.nocfbot is what the v7 patch does with
> today's HEAD (it's the same as before). The v8 patch makes all those
> changes and in addition makes the ones shown in v8-0001.diff.nocfbot.
> I think those are pretty much all improvements, except that it kind
> of messes up Martin Utesch's ASCII-art signatures in the geqo files.

Agreed, although this one now seems to use even more vertical space
that doesn't contain anything:

-/* Function works as follows:
+/*
+ * Function works as follows:
+ *
*
*
- * */
+ */

--
John Naylor
Amazon Web Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-05-11 05:04:54 Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
Previous Message Ayush Tiwari 2026-05-11 04:34:38 Question about hashed ScalarArrayOpExpr equality semantics