Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments

From: solaimurugan vellaipandiyan <drsolaimurugan(dot)v(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: John Naylor <johncnaylorls(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, Payal Singh <payals1(at)umbc(dot)edu>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
Date: 2026-05-11 11:04:20
Message-ID: CAHEL7KSLXoEa+ADPhCSFw1m79T3ppFhNxWm80gLqmgz148ce9A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tom,

I tested the proposed v8 patch on current HEAD.

I reran pgindent on files like contrib/seg/seg.c and
src/port/inet_aton.c, and the updated formatting looked more
consistent overall.
I also checked that repeated pgindent runs did not introduce
additional changes, and git diff --check was clean.
Additionally, the single-line comment case now stays unchanged as expected.
Overall, the new normalization behavior looks much cleaner and more
uniform in my testing.

Regards,
Solaimurugan V

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2026-05-11 11:04:39 Re: Include schema-qualified names in publication error messages.
Previous Message Rafia Sabih 2026-05-11 11:03:09 Re: Bypassing cursors in postgres_fdw to enable parallel plans