| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
| Subject: | Re: pg_migrator and handling dropped columns |
| Date: | 2009-02-12 18:39:06 |
| Message-ID: | 14562.1234463946@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> (4) add a switch to pg_dump to include dropped columns in its
>> schema output and then drop them. This seems far more maintainable
>> than writing separate code that tries to parse the output.
> I assume I would also drop the column in the pg_dump output.
Right, that's what I meant --- do all the work within pg_dump.
> Is this acceptable to everyone? We could name the option
> -u/--upgrade-compatible.
If the switch is specifically for pg_upgrade support (enabling this as
well as any other hacks we find necessary), which seems like a good
idea, then don't chew up a short option letter for it. There should be
a long form only. And probably not even list it in the user
documentation.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2009-02-12 18:41:25 | Re: pg_migrator and handling dropped columns |
| Previous Message | Tom Lane | 2009-02-12 18:34:11 | Re: DISCARD ALL failing to acquire locks on pg_listen |