Re: pg_migrator and handling dropped columns

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Subject: Re: pg_migrator and handling dropped columns
Date: 2009-02-12 18:46:42
Message-ID: 200902121846.n1CIkgR23648@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> (4) add a switch to pg_dump to include dropped columns in its
> >> schema output and then drop them. This seems far more maintainable
> >> than writing separate code that tries to parse the output.
>
> > I assume I would also drop the column in the pg_dump output.
>
> Right, that's what I meant --- do all the work within pg_dump.
>
> > Is this acceptable to everyone? We could name the option
> > -u/--upgrade-compatible.
>
> If the switch is specifically for pg_upgrade support (enabling this as
> well as any other hacks we find necessary), which seems like a good
> idea, then don't chew up a short option letter for it. There should be
> a long form only. And probably not even list it in the user
> documentation.

OK, works for me; any objections from anyone?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-02-12 18:47:12 Re: pg_migrator and handling dropped columns
Previous Message Tom Lane 2009-02-12 18:42:11 Re: GIN fast insert