Re: Alpha4 release blockers (was Re: wrapping up this CommitFest)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Rémi Zara <remi_zara(at)mac(dot)com>, Stefan Huehner <stefan(at)huehner(dot)org>
Subject: Re: Alpha4 release blockers (was Re: wrapping up this CommitFest)
Date: 2011-03-06 17:16:48
Message-ID: 15626.1299431808@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> - fmgr_info_collation(irel->rd_index->indcollation.values[attnum-1],
> + fmgr_info_collation(irel->rd_indcollation[attnum-1],
> locinfo);

BTW, I went ahead and committed this part, since the bug and the fix are
clear. I'm still not thrilled with the plan of sprinkling the code with
random fmgr_info_collation() calls to make up for the lack of a sane
default. IMO, that *is* a default, just a badly implemented one.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-03-06 19:54:28 Re: Sync Rep v19
Previous Message Magnus Hagander 2011-03-06 17:14:18 Downtime for commitfest.postgresql.org