| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: "long" type is not appropriate for counting tuples |
| Date: | 2019-07-02 20:56:01 |
| Message-ID: | 12946.1562100961@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> Attached is a patch to implement this in a handful of cases that are
> particularly verbose right now. I think those are easy wins.
> (Also a second patch that makes use of %zu for size_t where this was not
> yet done.)
I took a look through these and see nothing objectionable. There are
probably more places that can be improved, but we need not insist on
getting every such place in one go.
Per Robert's position that variables ought to have well-defined widths,
there might be something to be said for not touching the variable
declarations that you changed from int64 to long long, and instead
casting them to long long in the sprintf calls. But I'm not really
convinced that that's better than what you've done.
Marked CF entry as ready-for-committer.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-07-02 22:35:39 | Re: benchmarking Flex practices |
| Previous Message | Daniel Gustafsson | 2019-07-02 20:38:32 | Re: [PATCH v5] Show detailed table persistence in \dt+ |